fix: Lowering crash with supertrait predicates #21364
Merged
+78
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Wilfred
force-pushed
the
fix_cycle_projections
branch
from
823abe7 to
b624a18
Compare
This comment has been minimized.
This comment has been minimized.
ChayimFriedman2
requested changes
Dec 29, 2025
Wilfred
force-pushed
the
fix_cycle_projections
branch
from
b624a18 to
6e4df21
Compare
Wilfred
changed the title
Wilfred
force-pushed
the
fix_cycle_projections
branch
from
6e4df21 to
1cd2211
Compare
Contributor
Author
|
OK, I think this code is good to go now. Let me know what you think. |
ChayimFriedman2
approved these changes
Jan 11, 2026
Contributor
ChayimFriedman2
left a comment
ChayimFriedman2
left a comment
There was a problem hiding this comment.
LGTM, minus one nit. Also rebase.
Previously both valid and invalid Rust code could crash r-a due to a cyclic query during lowering.
Wilfred
force-pushed
the
fix_cycle_projections
branch
from
1cd2211 to
236e2db
Compare
Contributor
Author
|
Rebased and resolved all comments :) |
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously both valid and invalid Rust code could crash r-a due to a cyclic query during lowering.
Closes #21006
AI disclosure: I haven't worked on the lowerer before, so I created the first draft of this code with Claude. However, I've reviewed all the code myself (to the best of my ability), wrote the comments myself, verified that the added test fails without these changes, and I will apply my human brain to any feedback on the PR. I hope that's OK.